Repository navigation
Move to Hugo v0.169.0 and the latest site-commons - #562
Merged
Merged
Conversation
See SpineEventEngine/documentation#89. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since v0.162.0, Hugo denies `text/html` content files by default. The full-screen architecture diagram that `documentation/docs` brings in is one, so the build fails on newer Hugo. Hugo ignores the `security` settings of an imported module, so the site config allows HTML itself. See SpineEventEngine/documentation#92. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The theme now bundles the code-highlighting palettes into `main.css` and requires Hugo v0.169.0 and Go 1.27.3. `go mod` raised the `go` directive of `site/go.mod` to match. `check-links.yml` comes from `config`, which needs the same bump. See SpineEventEngine/documentation#89. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Hugo denies Org mode content files by default too, which is why the comment says Org mode stays denied. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approved
No active review issues are identified for the Hugo and dependency upgrade.
No open issues 🎉
What changed in this PR
Updates the spine.io site to Hugo v0.169.0 and the latest site-commons, aligning dependencies, CI, and contributor prerequisites.
Changes:
- Updates
site-commonsand raises the Go requirement to 1.27.3. - Allows imported HTML content, including the full-screen architecture diagram, while keeping Org mode denied.
- Updates CI Hugo versions and documents prerequisites and upgrade verification.
| File | Description |
|---|---|
site/go.sum |
Adds checksums for the updated theme module. |
site/go.mod |
Updates site-commons and the Go requirement. |
site/config/_default/hugo.toml |
Allows HTML content while denying Org mode. |
README.md |
Updates Go and Hugo prerequisites. |
docs/project.md |
Updates the required Hugo Extended version. |
.github/workflows/gh-pages.yml |
Pins deployment to Hugo v0.169.0. |
.github/workflows/check-links.yml |
Pins link-check builds to Hugo v0.169.0. |
.agents/tasks/hugo-0-169-upgrade.md |
Records the upgrade plan and verification results. |
Review effort: Balanced
Move `documentation/docs` to the `documentation` master, which has SpineEventEngine/documentation#94 merged. That PR changes only `docs/_preview`, a separate Go module, so the imported content and the built site stay the same; only the pinned version changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the site to Hugo v0.169.0 and the latest
site-commons. It is thespine.iopart of SpineEventEngine/documentation#89.Changes
text/htmlcontent files by default. The full-screen architecture diagram thatdocumentation/docsbrings in is one, so the build fails withaccess denied: "text/html" is not whitelisted in policy "security.allowContent". Hugo ignores thesecuritysettings of an imported module, sosite/config/_default/hugo.tomlnow setsallowContent = ['! ^text/org$']itself: HTML is allowed, Org mode stays denied.site-commonstob79100d8a139. The theme now bundles the code-highlighting palettes intomain.css(Bundle the code-highlighting palettes into the SCSS (option B of #35) site-commons#37) and requires Hugo v0.169.0 and Go 1.27.3.go modraised thegodirective ofsite/go.modto1.27.3.HUGO_VERSIONingh-pages.ymlandcheck-links.yml.README.mdanddocs/project.md.documentation/docsto3045fa4, thedocumentationmaster with Move to Hugo v0.169.0 and the latestsite-commonsdocumentation#94 merged. That PR changes onlydocs/_preview, a separate Go module, so the imported files are the same and so is the built site. Only the pinned version changes..agents/tasks/hugo-0-169-upgrade.md.Note
check-links.ymlcomes fromconfig, which still pinsHUGO_VERSION: 0.161.1. SpineEventEngine/config#823 makes the same bump there. Until it merges, the next./config/pullwould revert this line.Build evidence
Local Hugo v0.169.0 extended, Go 1.27.3, from
site/:hugo --minifyhugo -e developmentThe only warning in both builds is the theme's LibSass deprecation (
css.Sass: libsass was deprecated in Hugo v0.153.0), which was there before this change./docs/introduction/diagrams/spine-architecture-diagram-full-screen/renders in both builds:js/docs/architecture-diagram.min.<hash>.jsin production,js/docs/architecture-diagram.jsin development. The production file is byte-identical to the one live on spine.io (same fingerprint8009f824…);/docs/introduction/diagrams/Spine-Architecture-Diagram.pdfis published and served asapplication/pdf.In the browser, the diagram page and its script work. The page logs one error,
Cannot read properties of null (reading '__k'), which also shows on live spine.io, so it is not from this PR.What changes in the output
I built this branch twice on v0.169.0, once with the old theme and once with the new one, then diffed the output. Apart from whitespace that the new theme trims, the pages change only as site-commons#37 intends:
<link id="code-theme-css">and no/code-theme/{dark,light}.css; the palettes are inmain.css(127.chromarules, 4 before);On
/docs/quick-start/, the code-theme toggle switchesdata-themeand the token colors between the two palettes.CI and Go 1.27.3
gh-pages.ymlhas nosetup-gostep, so Hugo runs the runner's preinstalled Go. I simulated that with Go 1.26.4 onPATHand an empty Hugo module cache. Hugo passes noGOTOOLCHAIN, sogoruns with the defaultauto: it printedgo: downloading go1.27.3, fetched the modules, andhugo --minifypassed.Pre-PR checklist
version.gradle.kts).review-docs: approved. I applied its nit on theallowContentcomment: Hugo denies Org mode files by default too.check-links: the Lychee run that CI does passes, but it only sees<head>URLs. The inline jQuery block in every page's<head>stops Lychee from extracting body links, and CI has the same blind spot (also onmaster). Serve jQuery as a file so Lychee checks body links site-commons#39 fixes it. With that block stripped, 10 URLs are broken. Amasterbuild has the same ones: 9 in thevalidation/docsmodule and the Gitter link in the 1.0 blog post, which now redirects. None comes from this PR.See SpineEventEngine/documentation#89, SpineEventEngine/documentation#92.
🤖 Generated with Claude Code